Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change log level for log line in OBO Authenticator if OBO is disabled #4952

Merged
merged 1 commit into from
Dec 6, 2024

Conversation

cwperks
Copy link
Member

@cwperks cwperks commented Dec 5, 2024

Description

Found another log message where the level is set to error, but should be set to a lower level. Setting this log line to debug as this is not indicative of an error in the application.

  • Category (Enhancement, New feature, Bug fix, Test fix, Refactoring, Maintenance, Documentation)

Maintenance

Check List

  • New functionality includes testing
  • New functionality has been documented
  • New Roles/Permissions have a corresponding security dashboards plugin PR
  • API changes companion pull request created
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link

codecov bot commented Dec 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.46%. Comparing base (67f378a) to head (47736a0).
Report is 4 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #4952   +/-   ##
=======================================
  Coverage   71.46%   71.46%           
=======================================
  Files         334      334           
  Lines       22551    22551           
  Branches     3590     3590           
=======================================
+ Hits        16115    16116    +1     
- Misses       4639     4642    +3     
+ Partials     1797     1793    -4     
Files with missing lines Coverage Δ
...nsearch/security/http/OnBehalfOfAuthenticator.java 89.38% <100.00%> (ø)

... and 6 files with indirect coverage changes

@willyborankin willyborankin merged commit a1d4408 into opensearch-project:main Dec 6, 2024
42 of 43 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Dec 6, 2024
…#4952)

Signed-off-by: Craig Perkins <[email protected]>
(cherry picked from commit a1d4408)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x backport to 2.x branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants